Update comments and docstrings related to binder #18611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
approved these changes
Feb 5, 2025
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Nice! Have just one suggestion.
| or the result of isinstance checks. It also records whether it is | ||
| possible to reach that point at all. | ||
| or the result of isinstance checks and other type narrowing | ||
| operations. It also records whether it is possible to reach that |
Member
There was a problem hiding this comment.
You can also mention that isinstance() etc. follow a more direct path via put(), while assignments have some additional special-casing and first go via assign_type().
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
Hopefully this makes this a little less confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this makes this a little less confusing.